Bladeren bron

antialiasing related tweaks (combat blurriness)

- increase default line and point size
- reduce subpixel quality in fxaa
Alexander Rose 4 jaren geleden
bovenliggende
commit
070a15d679

+ 2 - 2
src/mol-canvas3d/passes/postprocessing.ts

@@ -101,7 +101,7 @@ export const PostprocessingParams = {
             edgeThresholdMin:PD.Numeric(0.0312, { min: 0.0312, max: 0.0833, step: 0.0001 }, { description: 'Trims the algorithm from processing darks.' }),
             edgeThresholdMax: PD.Numeric(0.063, { min: 0.063, max: 0.333, step: 0.001 }, { description: 'The minimum amount of local contrast required to apply algorithm.' }),
             iterations: PD.Numeric(12, { min: 0, max: 32, step: 1 }, { description: 'Number of edge exploration steps.' }),
-            subpixelQuality: PD.Numeric(1.00, { min: 0.00, max: 1.00, step: 0.01 }, { description: 'Choose the amount of sub-pixel aliasing removal.' }),
+            subpixelQuality: PD.Numeric(0.30, { min: 0.00, max: 1.00, step: 0.01 }, { description: 'Choose the amount of sub-pixel aliasing removal.' }),
         }),
         off: PD.Group({})
     }, { cycle: true, description: 'Fast Approximate Anti-Aliasing (FXAA)' }),
@@ -293,7 +293,7 @@ function getFxaaRenderable(ctx: WebGLContext, colorTexture: Texture): FxaaRender
         dEdgeThresholdMin: ValueCell.create(0.0312),
         dEdgeThresholdMax: ValueCell.create(0.125),
         dIterations: ValueCell.create(12),
-        dSubpixelQuality: ValueCell.create(0.75),
+        dSubpixelQuality: ValueCell.create(0.3),
     };
 
     const schema = { ...FxaaSchema };

+ 1 - 1
src/mol-geo/geometry/lines/lines.ts

@@ -164,7 +164,7 @@ export namespace Lines {
 
     export const Params = {
         ...BaseGeometry.Params,
-        sizeFactor: PD.Numeric(1, { min: 0, max: 10, step: 0.1 }),
+        sizeFactor: PD.Numeric(1.5, { min: 0, max: 10, step: 0.1 }),
         lineSizeAttenuation: PD.Boolean(false),
     };
     export type Params = typeof Params

+ 1 - 1
src/mol-geo/geometry/points/points.ts

@@ -119,7 +119,7 @@ export namespace Points {
 
     export const Params = {
         ...BaseGeometry.Params,
-        sizeFactor: PD.Numeric(1, { min: 0, max: 10, step: 0.1 }),
+        sizeFactor: PD.Numeric(1.5, { min: 0, max: 10, step: 0.1 }),
         pointSizeAttenuation: PD.Boolean(false),
         pointFilledCircle: PD.Boolean(false),
         pointEdgeBleach: PD.Numeric(0.2, { min: 0, max: 1, step: 0.05 }),

+ 1 - 1
src/mol-repr/structure/representation/line.ts

@@ -23,7 +23,7 @@ const LineVisuals = {
 export const LineParams = {
     ...IntraUnitBondLineParams,
     ...InterUnitBondLineParams,
-    sizeFactor: PD.Numeric(1.0, { min: 0.01, max: 10, step: 0.01 }),
+    sizeFactor: PD.Numeric(1.5, { min: 0.01, max: 10, step: 0.01 }),
     unitKinds: getUnitKindsParam(['atomic']),
     visuals: PD.MultiSelect(['intra-bond', 'inter-bond'], PD.objectToOptions(LineVisuals))
 };