فهرست منبع

Found a bug in withSameAtomProperties in filter.ts, where propSet and currentProps are placed inversely in isSuperSet()

yakomaxa 2 سال پیش
والد
کامیت
0f799d44ad
2فایلهای تغییر یافته به همراه2 افزوده شده و 2 حذف شده
  1. 1 1
      src/mol-model/structure/query/queries/filters.ts
  2. 1 1
      src/mol-plugin-state/transforms/model.ts

+ 1 - 1
src/mol-model/structure/query/queries/filters.ts

@@ -129,7 +129,7 @@ export function withSameAtomProperties(query: StructureQuery, propertySource: St
         StructureSelection.forEach(sel, (s, i) => {
             ctx.currentStructure = s;
             const currentProps = getCurrentStructurePropertiesInternal(ctx, props, new Set());
-            if (SetUtils.isSuperset(currentProps, propSet)) {
+            if (SetUtils.isSuperset(propSet,currentProps)) {
                 ret.add(s);
             }
 

+ 1 - 1
src/mol-plugin-state/transforms/model.ts

@@ -786,7 +786,7 @@ const StructureSelectionFromScript = PluginStateTransform.BuiltIn({
     from: SO.Molecule.Structure,
     to: SO.Molecule.Structure,
     params: () => ({
-        script: PD.Script({ language: 'vmd', expression: 'all' }),
+        script: PD.Script({ language: 'pymol', expression: 'all' }),
         label: PD.Optional(PD.Text(''))
     })
 })({