Browse Source

changelog & fix clipping exclude group filtering

Alexander Rose 3 years ago
parent
commit
7c93e9f834
2 changed files with 4 additions and 3 deletions
  1. 2 0
      CHANGELOG.md
  2. 2 3
      src/mol-plugin-state/helpers/structure-clipping.ts

+ 2 - 0
CHANGELOG.md

@@ -14,6 +14,8 @@ Note that since we don't clearly distinguish between a public and private interf
     - Combine pickObject/pickInstance/pickGroup shader variants into one
     - Combine markingDepth/markingMask shader variants into one
     - Correctly set shader define flags for overpaint, transparency, substance, clipping
+- [Breaking] Add per-object clip rendering properties (variant/objects)
+    - ``SimpleSettingsParams.clipping.variant/objects`` and ``RendererParams.clip`` were removed
 
 ## [v3.0.0-dev.6] - 2021-12-19
 

+ 2 - 3
src/mol-plugin-state/helpers/structure-clipping.ts

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) 2019-2020 mol* contributors, licensed under MIT, See LICENSE file for more info.
+ * Copyright (c) 2019-2021 mol* contributors, licensed under MIT, See LICENSE file for more info.
  *
  * @author Alexander Rose <alexander.rose@weirdbyte.de>
  * @author David Sehnal <david.sehnal@gmail.com>
@@ -59,8 +59,7 @@ async function eachRepr(plugin: PluginContext, components: StructureComponentRef
 
 /** filter clipping layers for given structure */
 function getFilteredBundle(layers: Clipping.BundleLayer[], structure: Structure) {
-    // TODO
-    const clipping = Clipping.Empty; // ofBundle(layers, structure.root);
+    const clipping = Clipping.ofBundle(layers, structure.root);
     const merged = Clipping.merge(clipping);
     return Clipping.filter(merged, structure);
 }