Forráskód Böngészése

mol-plugin: measurement tweak and todo

David Sehnal 5 éve
szülő
commit
a3b1d11bb3

+ 6 - 5
src/mol-plugin/state/transforms/model.ts

@@ -670,17 +670,17 @@ const ShapeFromPly = PluginStateTransform.BuiltIn({
     }
 });
 
-export { MultiStructureSelection }
+export { MultiStructureMeasurementSelection }
 type MultiStructureSelectionCacheEntry = {
     ref: string,
     expression: Expression,
     compiled: QueryFn<Sel>,
     source: Structure
 }
-type MultiStructureSelection = typeof MultiStructureSelection
-const MultiStructureSelection = PluginStateTransform.BuiltIn({
-    name: 'structure-multi-selection-from-expression',
-    display: { name: 'Multi-structure Selection', description: 'Create selection object from multiple structures.' },
+type MultiStructureMeasurementSelection = typeof MultiStructureMeasurementSelection
+const MultiStructureMeasurementSelection = PluginStateTransform.BuiltIn({
+    name: 'structure-multi-measurement-selection-from-expression',
+    display: { name: 'Multi-structure Measurement Selection', description: 'Create selection object from multiple structures.' },
     from: SO.Root,
     to: SO.Molecule.Structure.Selections,
     params: {
@@ -719,6 +719,7 @@ const MultiStructureSelection = PluginStateTransform.BuiltIn({
         return new SO.Molecule.Structure.Selections(loci, props);
     },
     // TODO: implement this
+    // TODO: check if the "next structures" are structurally equivalent and then the loci could be simply re-mapped!!!
     // update: ({ a, b, oldParams, newParams, cache }) => {
     //     if (oldParams.expression !== newParams.expression) return StateTransformer.UpdateResult.Recreate;
 

+ 1 - 1
src/mol-plugin/util/structure-measurement.ts

@@ -35,7 +35,7 @@ class StructureMeasurementManager {
         arraySetAdd(dependsOn, cellB.transform.ref);
 
         const update = this.getGroup();
-        update.apply(StateTransforms.Model.MultiStructureSelection, {
+        update.apply(StateTransforms.Model.MultiStructureMeasurementSelection, {
             selections: [
                 { ref: cellA.transform.ref, expression: StructureElement.Loci.toExpression(a) },
                 { ref: cellB.transform.ref, expression: StructureElement.Loci.toExpression(b) }