Ver Fonte

mol-canvas3d: tweaked Trackball.maxDistance

David Sehnal há 6 anos atrás
pai
commit
c19d28e36d
2 ficheiros alterados com 1 adições e 9 exclusões
  1. 1 1
      src/mol-canvas3d/controls/trackball.ts
  2. 0 8
      src/mol-plugin/state.ts

+ 1 - 1
src/mol-canvas3d/controls/trackball.ts

@@ -25,7 +25,7 @@ export const TrackballControlsParams = {
     dynamicDampingFactor: PD.Numeric(0.2, {}, { isHidden: true }),
 
     minDistance: PD.Numeric(0.01, {}, { isHidden: true }),
-    maxDistance: PD.Numeric(Infinity, {}, { isHidden: true })
+    maxDistance: PD.Numeric(1e150, {}, { isHidden: true })
 }
 export type TrackballControlsProps = PD.Values<typeof TrackballControlsParams>
 

+ 0 - 8
src/mol-plugin/state.ts

@@ -52,14 +52,6 @@ class PluginState {
     }
 
     async setSnapshot(snapshot: PluginState.Snapshot) {
-        // TODO
-        // JSON.stringify of Infinity => null ... is this a good place to fix it?
-        if (snapshot.canvas3d && snapshot.canvas3d.viewport && snapshot.canvas3d.viewport.trackball) {
-            if (snapshot.canvas3d.viewport.trackball.maxDistance === null) {
-                snapshot.canvas3d.viewport.trackball.maxDistance = Infinity;
-            }
-        }
-
         await this.plugin.runTask(this.behaviorState.setSnapshot(snapshot.behaviour));
         await this.plugin.runTask(this.dataState.setSnapshot(snapshot.data));
         PluginCommands.Canvas3D.SetSettings.dispatch(this.plugin, { settings: snapshot.canvas3d.viewport || { } });