ソースを参照

Merge branch 'master' into animation-once-stops

David Sehnal 2 年 前
コミット
e2cdc45be6
2 ファイル変更2 行追加1 行削除
  1. 1 0
      CHANGELOG.md
  2. 1 1
      src/mol-gl/shader/chunks/apply-light-color.glsl.ts

+ 1 - 0
CHANGELOG.md

@@ -7,6 +7,7 @@ Note that since we don't clearly distinguish between a public and private interf
 ## [Unreleased]
 
 - Fix 'once' for animations of systems with many frames
+- Better guard against issue (black fringes) with bumpiness in impostors
 
 ## [v3.26.0] - 2022-12-04
 

+ 1 - 1
src/mol-gl/shader/chunks/apply-light-color.glsl.ts

@@ -12,7 +12,7 @@ export const apply_light_color = `
     gl_FragColor = material;
 #else
     #ifdef bumpEnabled
-        if (uBumpFrequency > 0.0 && uBumpAmplitude > 0.0) {
+        if (uBumpFrequency > 0.0 && uBumpAmplitude > 0.0 && bumpiness > 0.0) {
             normal = perturbNormal(-vViewPosition, normal, fbm(vModelPosition * uBumpFrequency), (uBumpAmplitude * bumpiness) / uBumpFrequency);
         }
     #endif